codeant-ai-for-open-source[bot] commented on code in PR #36996:
URL: https://github.com/apache/superset/pull/36996#discussion_r2674869529
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -354,12 +354,11 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
defaultOpen={show}
open={show}
onOpenChange={toggleOverlay}
- overlayStyle={{ width: '600px' }}
+ overlayStyle={{ width: '600px', zIndex: 1050 }}
Review Comment:
**Suggestion:** Fixed pixel `width: '600px'` on the popover overlay can
cause overflow or horizontal clipping on narrow viewports; use a responsive
constraint such as `maxWidth` (numeric) so the popover can shrink on small
screens and avoid layout breakage. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
overlayStyle={{ maxWidth: 600, zIndex: 1050 }}
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
UX/visual bug fix: fixed 600px width may cause horizontal overflow on small
screens.
Using maxWidth (or responsive CSS) allows the popover to shrink and avoid
layout breakage.
This directly improves behavior visible to users.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
**Line:** 356:357
**Comment:**
*Logic Error: Fixed pixel `width: '600px'` on the popover overlay can
cause overflow or horizontal clipping on narrow viewports; use a responsive
constraint such as `maxWidth` (numeric) so the popover can shrink on small
screens and avoid layout breakage.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
