codeant-ai-for-open-source[bot] commented on PR #37024: URL: https://github.com/apache/superset/pull/37024#issuecomment-3731050437
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37024/files#diff-81ae035c26bd2c0b34c0fe94ded219dd644fb5247587036cb536bfbe705e5428R219-R230'><strong>Missing negative assertion</strong></a><br>The test no longer verifies that manifest-writing code is not invoked when backend files change. The original test checked `write_manifest`; removing that assertion could allow accidental manifest writes for backend changes to go undetected.<br> - [ ] <a href='https://github.com/apache/superset/pull/37024/files#diff-81ae035c26bd2c0b34c0fe94ded219dd644fb5247587036cb536bfbe705e5428R219-R230'><strong>Weak test coverage</strong></a><br>The new backend watcher test only calls the mocked `rebuild_backend` directly instead of exercising the actual watcher function/handler. This means the test doesn't validate the logic in the code under test (e.g., that backend changes don't attempt to write the manifest) and can let regressions pass.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
