michael-s-molina commented on code in PR #37024:
URL: https://github.com/apache/superset/pull/37024#discussion_r2681927054
##########
superset-extensions-cli/tests/test_cli_dev.py:
##########
@@ -216,23 +216,15 @@ def
test_frontend_watcher_function_coverage(isolated_filesystem):
@pytest.mark.unit
def test_backend_watcher_function_coverage(isolated_filesystem):
- """Test backend watcher function for coverage."""
- # Create dist directory with manifest
- dist_dir = isolated_filesystem / "dist"
- dist_dir.mkdir()
-
- manifest_data = {"name": "test", "version": "1.0.0"}
- (dist_dir / "manifest.json").write_text(json.dumps(manifest_data))
+ """Test backend watcher function only rebuilds backend files."""
+ # Create backend directory
+ backend_dir = isolated_filesystem / "backend"
+ backend_dir.mkdir()
Review Comment:
@villebro This suggestion makes the code more resilient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]