codeant-ai-for-open-source[bot] commented on code in PR #37024:
URL: https://github.com/apache/superset/pull/37024#discussion_r2677972358
##########
superset-extensions-cli/tests/test_cli_dev.py:
##########
@@ -216,23 +216,15 @@ def
test_frontend_watcher_function_coverage(isolated_filesystem):
@pytest.mark.unit
def test_backend_watcher_function_coverage(isolated_filesystem):
- """Test backend watcher function for coverage."""
- # Create dist directory with manifest
- dist_dir = isolated_filesystem / "dist"
- dist_dir.mkdir()
-
- manifest_data = {"name": "test", "version": "1.0.0"}
- (dist_dir / "manifest.json").write_text(json.dumps(manifest_data))
+ """Test backend watcher function only rebuilds backend files."""
+ # Create backend directory
+ backend_dir = isolated_filesystem / "backend"
+ backend_dir.mkdir()
Review Comment:
**Suggestion:** Creating the backend directory with plain `mkdir()` can
raise FileExistsError if the directory already exists (test environments may
reuse or create it earlier); use `mkdir(..., parents=True, exist_ok=True)` to
make the test idempotent and robust. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
backend_dir.mkdir(parents=True, exist_ok=True)
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
Making the test directory creation idempotent is a sensible defensive change
for tests that may be run in non-pristine environments or reused fixtures.
Using mkdir(parents=True, exist_ok=True) avoids flaky FileExistsError without
changing test semantics. This is a correctness/robustness improvement and
doesn't require broader changes.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-extensions-cli/tests/test_cli_dev.py
**Line:** 222:222
**Comment:**
*Possible Bug: Creating the backend directory with plain `mkdir()` can
raise FileExistsError if the directory already exists (test environments may
reuse or create it earlier); use `mkdir(..., parents=True, exist_ok=True)` to
make the test idempotent and robust.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
