FelipeGLopez commented on code in PR #36708:
URL: https://github.com/apache/superset/pull/36708#discussion_r2688734031
##########
superset-frontend/src/explore/actions/saveModalActions.ts:
##########
@@ -253,6 +286,12 @@ export const updateSlice =
dispatch(saveSliceSuccess(response.json));
addToasts(false, sliceName, addedToDashboard).map(dispatch);
+
+ // Broadcast update to other tabs
+ if (formData) {
+ broadcastChartUpdate(sliceId, formData as QueryFormData);
+ }
Review Comment:
I added a couple of tests more that cover different cases
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -161,6 +161,18 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
};
}, [dashboardPageId]);
+ // Set up cross-tab chart update listener
+ useEffect(() => {
+ const {
+ initChartUpdateChannel,
+ closeChartUpdateChannel,
+ } = require('src/dashboard/util/chartUpdateChannel');
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
