FelipeGLopez commented on code in PR #36708:
URL: https://github.com/apache/superset/pull/36708#discussion_r2688764495
##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -363,6 +363,11 @@ export function updateQueryFormData(value, key) {
return { type: UPDATE_QUERY_FORM_DATA, value, key };
}
+export const UPDATE_CHART_FORM_DATA = 'UPDATE_CHART_FORM_DATA';
+export function updateChartFormDataAction(formData, chartId) {
+ return { type: UPDATE_CHART_FORM_DATA, formData, chartId };
+}
Review Comment:
I forgot one thing to mention today, but this one is for a totally different
purpose than `UPDATE_QUERY_FORM_DATA`.
`UPDATE_QUERY_FORM_DATA` only updates `latestQueryFormData` (form data used
for the current query), while `UPDATE_CHART_FORM_DATA` updates both `form_data`
(persisted chart state) and `latestQueryFormData`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
