rusackas commented on code in PR #37107:
URL: https://github.com/apache/superset/pull/37107#discussion_r2728889841
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -149,11 +147,29 @@ const ReturnedRows = styled.div`
line-height: 1;
`;
+const ResultSetControls = styled.div`
Review Comment:
Good catch\! You're right - this file was accidentally overwritten with an
older version. I've fixed it by rebasing on master and keeping only the
intended change: `mountExploreUrl(null, ...)` → `mountExploreUrl('base', ...)`
for TypeScript compatibility. The rest of the file now matches master.
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -291,7 +307,7 @@ const ResultSet = ({
const force = false;
const includeAppRoot = openInNewWindow;
const url = mountExploreUrl(
- null,
+ 'base',
Review Comment:
Exactly right - the `mountExploreUrl('base', ...)` change was the only
intended fix for TypeScript type compatibility. Fixed now\!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
