rusackas commented on PR #37107:
URL: https://github.com/apache/superset/pull/37107#issuecomment-3801274534
## Updates Made
### Resolved Conflicts
Rebased on master and properly resolved the `ResultSet/index.tsx` conflict.
The file was accidentally overwritten with an older version - now it matches
master with only the intended TypeScript fix: `mountExploreUrl(null, ...)` →
`mountExploreUrl('base', ...)`.
### Addressed Bito Review Suggestion
Fixed the unsafe `Response` cast in `chartAction.ts` catch block (line
636-637). Removed the explicit type annotation and cast, allowing
`getClientErrorObject` to handle response typing internally - matching the
pattern used elsewhere in the codebase.
### Bito Suggestions Not Addressed (Low Priority)
The following "Additional Suggestions" were reviewed but not addressed as
they're either consistent with existing patterns or low impact:
- `useExploreAdditionalActionsMenu/index.tsx:964` - The `QueryFormData` cast
is consistent with the file's existing pattern and would require larger
refactoring to improve
- `useExploreAdditionalActionsMenu/index.tsx:891-894` - The `onClick: () =>
void` type works correctly since handlers don't use the event parameter
- `ExploreChartPanel/index.tsx:91` - The `exploreState` prop is declared but
unused; changing to `ExploreState` has minimal impact
All pre-commit checks pass ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
