bito-code-review[bot] commented on code in PR #37107:
URL: https://github.com/apache/superset/pull/37107#discussion_r2729438991
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -305,8 +305,10 @@ function mapDispatchToProps(
dispatch: ThunkDispatch<any, undefined, AnyAction>,
) {
return {
- refreshAnnotationData: (annotationObj: Annotation) =>
- dispatch(runAnnotationQuery(annotationObj)),
+ refreshAnnotationData: (payload: Payload) =>
+ dispatch(
+ runAnnotationQuery(payload as Parameters<typeof
runAnnotationQuery>[0]),
+ ),
Review Comment:
<!-- Bito Reply -->
Your explanation aligns with common TypeScript migration practices. The cast
preserves runtime behavior without introducing immediate bugs, and documenting
it as technical debt is a solid approach. Just prioritize fixing the underlying
type mismatch in a dedicated refactor to avoid future issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
