EnxDev commented on PR #37461: URL: https://github.com/apache/superset/pull/37461#issuecomment-3812009964
@phmoraesrodrigues Thanks for working on this! The UX improvement of showing labels instead of raw column names in the Drill By modal is valuable. I noticed @semohr raised a concern about relying solely on label_map; it can miss `verbose_name` labels defined at the dataset level. PR #37396 addresses this same problem for the Explore view by introducing a `collabels` field computed via `extract_display_labels()`, which falls back to datasource metadata when `label_map` doesn't have the entry. We can wait for #37396 and reuse the collabels approach here for consistency or we can collaborate; perhaps the label resolution logic could be shared between both PRs What do you think? It might be worth syncing with @semohr to avoid duplicating effort and ensure consistent behavior across Explore and Drill By. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
