rusackas commented on code in PR #37107:
URL: https://github.com/apache/superset/pull/37107#discussion_r2751127999
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -149,11 +147,29 @@ const ReturnedRows = styled.div`
line-height: 1;
`;
+const ResultSetControls = styled.div`
Review Comment:
Both changes in this file are intentional:
1. **Line 301** (`mountExploreUrl(null, ...)` → `mountExploreUrl('base',
...)`): The TypeScript migration added a proper type to `mountExploreUrl` — the
first parameter is now `EndpointType | string`, which doesn't accept `null`.
Changed to `'base'` to match.
2. **Lines 428-432** (`columns` → `columns.map(c => c.column_name)`): The
`prepareCopyToClipboardTabularData` function's TS signature now accepts
`(string | ColumnDefinition)[]` where `ColumnDefinition` has a `name` property.
In ResultSet, `columns` are objects with `column_name` (not `name`), so we
extract the string values explicitly. The original JS handled this implicitly
via `getColumnName()`, but the TS types required being explicit at the call
site.
The file was not overwritten — only these two targeted changes were made,
both to satisfy new TypeScript types in the migrated utility functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
