YousufFFFF commented on issue #34352: URL: https://github.com/apache/superset/issues/34352#issuecomment-3839325537
Thanks @sfirke ! That makes sense, and I agree with the direction 👍 Just to clarify, this doesn’t seem like a regression, but more of a long-standing situation where the annotation options are exposed in the UI without actually being wired through to the annotation query logic. I’m happy to work on fixing this properly rather than limiting what users can do. My plan is to: - Start by wiring override time range, override time grain, and time shift for Time Series annotations - Fix the Title Column dropdown so it actually reflects valid string columns from the source chart - Then apply the same fixes to Event and Interval annotations so things behave consistently I’m thinking of doing this in a focused PR (starting with Time Series) and then following up for Event/Interval, but I’m flexible if you’d prefer it bundled differently. I’ll share updates on the issue once I have something working. Thanks again for the encouragement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
