kasiazjc commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3853592540
> > Sure, I'm definitely not opposed to it! We might want to think about other errors as well. Like if the connection is broken and the user tries to refresh the list of tables, should this error also show in this new/centralized place? > > That's probably a good question for @kasiazjc. My personal opinion is that "global" errors should use the modal or toast pattern and inline errors should be used when they affect a particular part of the screen but the remaining features still work. > > Losing connection is a global error, all features will be affected. So for the more global errors I am thinking: - [inline error](https://ant.design/~demos/form-demo-validate-static) on the specific field that triggered this (if there is one), so that the user sees the context (in this case it would be database) - there could be text underneath the field with short explanation and maybe a link? - I think I prefer banner over modal - modal is more disruptive and disappears after user closes it and what is important - they can't proceed without closing it really, so they lose all of the context. So because of that we have no context or the link to authorize connection etc. **I would vote for global modal displayed at the top of the section with SQL area** so: combination of both if that makes sense, banner only if simply global not triggered by a specific field Agree on the contextual inline for errors that only affect part of the screen. wdyt @michael-s-molina @Vitor-Avila ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
