kasiazjc commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3854107169
> > why my personal preference and sweet spot is banner/alert. > > Aren't banners and alerts inline components? > > <img alt="Screenshot 2026-02-05 at 11 23 16" width="1751" height="857" src="https://private-user-images.githubusercontent.com/70410625/545640058-e212599e-b52e-41ef-ac32-5453340ae0c3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDIwNDIsIm5iZiI6MTc3MDMwMTc0MiwicGF0aCI6Ii83MDQxMDYyNS81NDU2NDAwNTgtZTIxMjU5OWUtYjUyZS00MWVmLWFjMzItNTQ1MzM0MGFlMGMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5NzQ1ZTlhMGY1ZWU1NzEyMzQ3ZDUxZDhjMTY5YmJiZTM0YjY4ZThkMGRlYjAyMWJkZDUzOTdjYTVlMTk4NTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yqdV7PzBpngqZSXIFWjQj8Kjp2lgGMZx_7X3S_5q-8c";> > Do you mean toast? Which would be similar to Notification. I actually meant alert/banner, but true that technically they are inline (and in terms of inline - I was thinking more of field outline + metadata error text). Alert banners are commonly used for global/system-level errors though - there has to be right placement, so that's why I am thinking above SQL area and it's the most central option (at the top of the major section). The errors that were mentioned are blocking, and these two types of components we were talking about have different purposes/feel: - toast/notification - temporary and most of the time non-blocking (like download successful/unsuccessful) - banner - persistent, for system level issues and blocking actions (really requires user attention or action to resolve) users are more likely to dismiss the notification - I think authorization flow is critical, because otherwise they cannot do anything and with dismiss they are left with nothing - especially if they forgot to click on a link that was shown there (to complete it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/70410625/545640058-e212599e-b52e-41ef-ac32-5453340ae0c3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDIwNDIsIm5iZiI6MTc3MDMwMTc0MiwicGF0aCI6Ii83MDQxMDYyNS81NDU2NDAwNTgtZTIxMjU5OWUtYjUyZS00MWVmLWFjMzItNTQ1MzM0MGFlMGMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5NzQ1ZTlhMGY1ZWU1NzEyMzQ3ZDUxZDhjMTY5YmJiZTM0YjY4ZThkMGRlYjAyMWJkZDUzOTdjYTVlMTk4NTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yqdV7PzBpngqZSXIFWjQj8Kjp2lgGMZx_7X3S_5q-8c"](https://private-user-images.githubusercontent.com/70410625/545640058-e212599e-b52e-41ef-ac32-5453340ae0c3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDIwNDIsIm5iZiI6MTc3MDMwMTc0MiwicGF0aCI6Ii83MDQxMDYyNS81NDU2NDAwNTgtZTIxMjU5OWUtYjUyZS00MWVmLWFjMzItNTQ1MzM0MGFlMGMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5NzQ1ZTlhMGY1ZWU1NzEyMzQ3ZDUxZDhjMTY5YmJiZTM0YjY4ZThkMGRlYjAyMWJkZDUzOTdjYTVlMTk4NTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yqdV7PzBpngqZSXIFWjQj8Kjp2lgGMZx_7X3S_5q-8c"){kind=link}