Vitor-Avila commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3843236653
> @Vitor-Avila If I'm understanding this correctly, given that the token can be revoked at any time, multiple operations in SQL Lab would fail if a user does not have a valid token. This means that this error message should not be associated with any panel/selector. It's more of a modal/toast type of error message. cc @kasiazjc It depends on the implementation, previously we would show it relative/in/under the component that returned the error (example from when schema load failed): <img width="456" height="415" alt="image" src="https://github.com/user-attachments/assets/c5dea7f1-7b06-4d15-b1db-1c762c8d55ac"; /> We can definitely have it in a central place right now (or even make it trigger the dialog "expanded" directly: <img width="1317" height="425" alt="image" src="https://github.com/user-attachments/assets/59283e8a-66d9-41aa-b326-8d785bb77212"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
