albundy83 opened a new pull request, #38033: URL: https://github.com/apache/superset/pull/38033
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Continue to improve https://github.com/apache/superset/issues/26319 Fix https://github.com/apache/superset/issues/34552 ### TESTING INSTRUCTIONS - Have a nice kubernetes cluster (here rke2 1.34.3) - configure your wonderful superset to use oauth (for example keycloak) ```yaml envFromSecrets: - superset-oauth-providers # contains all my super secret keycloak stuff (urls and client_secret etc ...) configOverrides: enable_oauth: | from os import environ as env from flask_appbuilder.security.manager import (AUTH_DB, AUTH_OAUTH) AUTH_TYPE = AUTH_OAUTH OAUTH_PROVIDERS = [ { 'name': env.get('name'), 'icon': env.get('icon'), 'token_key': 'access_token', 'remote_app': { 'client_id': env.get('client_id'), 'client_secret': env.get('client_secret'), 'client_kwargs': { 'scope': env.get('client_kwargs_scope'), }, 'access_token_url': env.get('access_token_url'), 'api_base_url': env.get('api_base_url'), 'authorize_url': env.get('authorize_url'), 'server_metadata_url': env.get('server_metadata_url'), }, } ] # Map Authlib roles to superset roles AUTH_ROLE_ADMIN = 'Admin' AUTH_ROLE_PUBLIC = 'Public' # Will allow user self registration, allowing to create Flask users from Authorized User AUTH_USER_REGISTRATION = True # The default user self registration role AUTH_USER_REGISTRATION_ROLE = 'Admin' ``` - deploy using new beta feature [SUPERSET_APP_ROOT](https://github.com/apache/superset/issues/26319): ```yaml extraEnv: SUPERSET_APP_ROOT: /tableau ``` - connect for example to https://superset.youpi.fr/tableau using When you click on "Sign in with Keycloak" You first have a 404 as url is the like this: https://superset.youpi.fr/login/keycloak?next=%2Fsuperset%2Fwelcome%2F (sub url /tableau is missing) If you manually add /tableau, you will then have: https://superset.youpi.fr/superset/welcome/ (and still /tableau is missing) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
