albundy83 commented on PR #38033: URL: https://github.com/apache/superset/pull/38033#issuecomment-3985067494
Ah maybe it depends on which version you have applied my fix. The `makeUrl` has been added in 6.0.1rc1, see [here](https://github.com/apache/superset/blob/6.0.1rc1/superset-frontend/src/utils/pathUtils.ts#L42C17-L42C24) But, `makeUrl` and `ensureAppRoot` are exactly the same function, one return the other :) And your modifications are exactly the same than the one in pull request but with `ensureAppRoot` :) And if you want an improvement with your oauth, I have written a small doc with a more complete example [here](https://github.com/apache/superset/pull/38092/changes) Enjoy :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
