bito-code-review[bot] commented on code in PR #37973:
URL: https://github.com/apache/superset/pull/37973#discussion_r2891560452
##########
superset/mcp_service/auth.py:
##########
@@ -127,8 +159,8 @@ def get_user_from_request() -> User:
raise ValueError(
"No authenticated user found. Tried:\n"
+ "\n".join(f" - {d}" for d in details)
- + "\n\nEither pass a valid JWT bearer token or configure "
- "MCP_DEV_USERNAME for development."
+ + "\n\nEither pass a valid API key (Bearer sst_...), "
+ "JWT token, or configure MCP_DEV_USERNAME for development."
Review Comment:
<!-- Bito Reply -->
Yes, the suggestion is valid — it makes the error message configurable by
dynamically reading the API key prefix from FAB_API_KEY_PREFIXES config instead
of hardcoding 'sst_'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
