codeant-ai-for-open-source[bot] commented on code in PR #38563:
URL: https://github.com/apache/superset/pull/38563#discussion_r2917042125
##########
superset-frontend/src/pages/SqlLab/LocationContext.tsx:
##########
@@ -31,7 +31,9 @@ const { Provider } = locationContext;
const EMPTY_STATE: LocationState = {};
-export const LocationProvider: FC = ({ children }: { children: ReactNode }) =>
{
+export const LocationProvider: FC<{ children?: ReactNode }> = ({
+ children,
+}) => {
const location = useLocation<LocationState>();
if (location.state) {
return <Provider value={location.state}>{children}</Provider>;
Review Comment:
**Suggestion:** The context value can lack a `requestedQuery` object (e.g.,
when `location.state` is present without that field or when falling back to
`EMPTY_STATE`), but `PopEditorTab` unconditionally spreads `requestedQuery`
into a new object; if it is `undefined`, this will throw a runtime `TypeError:
Cannot convert undefined or null to object`. Normalizing the context so that
`requestedQuery` is always at least an empty object prevents this crash. [logic
error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Visiting SqlLab without query state crashes PopEditorTab.
- ❌ Direct navigation to '/sqllab' can break SQL Lab.
- ⚠️ Potential untested paths crash future SqlLab unit tests.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
