EnxDev commented on code in PR #38563:
URL: https://github.com/apache/superset/pull/38563#discussion_r2917289224
##########
superset-frontend/src/features/users/UserListModal.tsx:
##########
@@ -133,142 +134,146 @@ function UserListModal({
requiredFields={requiredFields}
initialValues={initialValues}
>
- {(form: FormInstance) => (
- <>
- <FormItem
- name="first_name"
- label={t('First name')}
- rules={[{ required: true, message: t('First name is required') }]}
- >
- <Input
+ {
+ ((form: FormInstance) => (
+ <>
+ <FormItem
name="first_name"
- placeholder={t("Enter the user's first name")}
- />
- </FormItem>
- <FormItem
- name="last_name"
- label={t('Last name')}
- rules={[{ required: true, message: t('Last name is required') }]}
- >
- <Input
+ label={t('First name')}
+ rules={[{ required: true, message: t('First name is required')
}]}
+ >
+ <Input
+ name="first_name"
+ placeholder={t("Enter the user's first name")}
+ />
+ </FormItem>
+ <FormItem
name="last_name"
- placeholder={t("Enter the user's last name")}
- />
- </FormItem>
- <FormItem
- name="username"
- label={t('Username')}
- rules={[{ required: true, message: t('Username is required') }]}
- >
- <Input
+ label={t('Last name')}
+ rules={[{ required: true, message: t('Last name is required') }]}
+ >
+ <Input
+ name="last_name"
+ placeholder={t("Enter the user's last name")}
+ />
+ </FormItem>
+ <FormItem
name="username"
- placeholder={t("Enter the user's username")}
- />
- </FormItem>
- <FormItem
- name="active"
- label={t('Is active?')}
- valuePropName="checked"
- >
- <Checkbox
- onChange={checked => {
- form.setFieldsValue({ isActive: checked });
- }}
- />
- </FormItem>
- <FormItem
- name="email"
- label={t('Email')}
- rules={[
- { required: true, message: t('Email is required') },
- {
- type: 'email',
- message: t('Please enter a valid email address'),
- },
- ]}
- >
- <Input name="email" placeholder={t("Enter the user's email")} />
- </FormItem>
- <FormItem
- name="roles"
- label={t('Roles')}
- dependencies={['groups']}
- rules={[atLeastOneRoleOrGroup('groups')]}
- >
- <Select
+ label={t('Username')}
+ rules={[{ required: true, message: t('Username is required') }]}
+ >
+ <Input
+ name="username"
+ placeholder={t("Enter the user's username")}
+ />
+ </FormItem>
+ <FormItem
+ name="active"
+ label={t('Is active?')}
+ valuePropName="checked"
+ >
+ <Checkbox
+ onChange={checked => {
+ form.setFieldsValue({ isActive: checked });
+ }}
+ />
Review Comment:
Since the FormItem already has `valuePropName="checked"`, antd handles the
checked state automatically via the form binding
```suggestion
<Checkbox />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
