bito-code-review[bot] commented on code in PR #38563:
URL: https://github.com/apache/superset/pull/38563#discussion_r2917597286
##########
superset-frontend/src/features/reports/ReportModal/index.tsx:
##########
@@ -366,7 +367,7 @@ function ReportModal({
}}
onError={setCronError}
/>
- <StyledCronError>{cronError}</StyledCronError>
+ <StyledCronError>{cronError as ReactNode}</StyledCronError>
<div
Review Comment:
<!-- Bito Reply -->
The suggestion modifies the error display to show `cronError?.description`
instead of casting `cronError` to `ReactNode`. This assumes `cronError` is an
object with a `description` property, potentially improving readability by
displaying a specific error message rather than the raw error object. However,
if `cronError` lacks a `description` field or is already a string, this might
not enhance the code and could lead to undefined display.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
