bito-code-review[bot] commented on code in PR #38416:
URL: https://github.com/apache/superset/pull/38416#discussion_r2931946291
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -137,6 +137,12 @@ class DatasetInfo(BaseModel):
is_favorite: bool | None = Field(
None, description="Whether this dataset is favorited by the current
user"
)
+ popularity_score: float | None = Field(
+ None,
+ description="Popularity score based on chart usage, certification, "
+ "and recency. Request via select_columns=['popularity_score'] or sort "
+ "via order_column='popularity_score'.",
+ )
model_config = ConfigDict(
Review Comment:
<!-- Bito Reply -->
Yes, the suggestion is valid — it adds the necessary import and logic to
compute and assign the popularity score for single dataset retrievals, ensuring
consistency with how popularity is handled in list operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
