Mayankaggarwal8055 commented on code in PR #38745:
URL: https://github.com/apache/superset/pull/38745#discussion_r2961260717
##########
superset-frontend/src/components/Modal/StandardModal.tsx:
##########
@@ -141,6 +144,9 @@ export function StandardModal({
title
)
}
+ $resizable={resizable}
Review Comment:
> wrongly duplicate `resizable` attribute here
Ah, good catch. That duplication wasn’t intentional—I’ll clean it up and
make sure the prop is passed correctly.
##########
superset-frontend/src/dashboard/components/PropertiesModal/sections/AdvancedSection.tsx:
##########
@@ -75,18 +75,20 @@ const AdvancedSection = ({
}
bottomSpacing={false}
>
- <StyledEditorHost
- id="dashboard-json-metadata"
- data-test="dashboard-metadata-editor"
- value={jsonMetadata}
- onChange={onJsonMetadataChange}
- language="json"
- tabSize={2}
- wordWrap
- width="100%"
- height="200px"
- annotations={toEditorAnnotations(jsonAnnotations)}
- />
+ <div style={{ minHeight: 300, height: '60vh' }}>
Review Comment:
I added that wrapper to handle flexible height after removing the fixed
200px, so the editor could grow with the modal.
But yeah, I see your point—it’s not the cleanest approach. I’ll refactor
this and handle the sizing more properly without the extra div.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
