bito-code-review[bot] commented on code in PR #38745:
URL: https://github.com/apache/superset/pull/38745#discussion_r2961802673
##########
superset-frontend/src/components/Modal/StandardModal.tsx:
##########
@@ -41,19 +41,19 @@ interface StandardModalProps {
maskClosable?: boolean;
wrapProps?: object;
contentLoading?: boolean;
+ resizable?: boolean;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing resizable prop forwarding</b></div>
<div id="fix">
The resizable prop has been added to the StandardModalProps interface, but
it's not being passed to the underlying Modal component. Without passing
resizable={resizable}, the modal will not be resizable even when the prop is
set to true. The Modal component from @superset-ui/core supports resizing via
the re-resizable library.
</div>
</div>
<small><i>Code Review Run #c9868a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
