codeant-ai-for-open-source[bot] commented on code in PR #38745:
URL: https://github.com/apache/superset/pull/38745#discussion_r2965538248
##########
superset-frontend/src/components/Modal/StandardModal.tsx:
##########
@@ -141,6 +142,7 @@ export function StandardModal({
title
)
}
+ $resizable={resizable}
Review Comment:
**Suggestion:** The `resizable` flag is only used for styling and is never
forwarded to the underlying `Modal` component, so resize handles and resize
behavior are never activated. Pass `resizable` through to `StyledModal` to
enable the actual modal resizing logic. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ⚠️ Dashboard PropertiesModal resize handles never appear.
- ⚠️ Modal.tsx resizable wrapper path never executes.
- ⚠️ Large JSON editing remains constrained to static modal.
```
</details>
```suggestion
resizable={resizable}
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In dashboard header actions, click "Edit properties"; `handleMenuClick`
routes
`MenuKeys.EditProperties` to `showPropertiesModal()` at
`superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx:34-36`.
2. `showPropertiesModal()` toggles modal state, then `Header` renders
`<PropertiesModal
... show={showingPropertiesModal} />` at
`superset-frontend/src/dashboard/components/Header/index.tsx:25-35` (shown
in returned JSX
block lines 25-35 of the read section).
3. `PropertiesModal` renders `<StandardModal ... resizable draggable ...>` at
`superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:22-32`,
so resize is
expected on this path.
4. In `StandardModal`, only `$resizable={resizable}` is passed
(`superset-frontend/src/components/Modal/StandardModal.tsx:145`), but
functional resize
logic in core `Modal` requires `resizable` prop
(`superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx:225,339,346-348`);
result: no `Resizable` wrapper/handles appear, modal cannot be resized.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/components/Modal/StandardModal.tsx
**Line:** 145:145
**Comment:**
*Logic Error: The `resizable` flag is only used for styling and is
never forwarded to the underlying `Modal` component, so resize handles and
resize behavior are never activated. Pass `resizable` through to `StyledModal`
to enable the actual modal resizing logic.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38745&comment_hash=550acf87500f7552ccaf4171c1c77665d9151789d6cfd89828dc221348baa92c&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38745&comment_hash=550acf87500f7552ccaf4171c1c77665d9151789d6cfd89828dc221348baa92c&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
