bito-code-review[bot] commented on code in PR #38745:
URL: https://github.com/apache/superset/pull/38745#discussion_r2968730318
##########
superset-frontend/src/components/Modal/StandardModal.tsx:
##########
@@ -41,19 +41,19 @@ interface StandardModalProps {
maskClosable?: boolean;
wrapProps?: object;
contentLoading?: boolean;
+ resizable?: boolean;
Review Comment:
<!-- Bito Reply -->
The review suggests making max-height conditional with 80vh for
non-resizable modals to fix the resizable behavior issue. The PR already
applies conditional logic but uses 60vh; updating to 80vh matches the
suggestion.
**superset-frontend/src/components/Modal/StandardModal.tsx**
```
const StyledModal = styled(Modal)<{ $resizable?: boolean }>`
.ant-modal-body {
max-height: ${({ $resizable }) => ($resizable ? 'none' : '80vh')};
height: auto;
overflow-y: auto;
padding: 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
