msyavuz commented on code in PR #38909:
URL: https://github.com/apache/superset/pull/38909#discussion_r3000665020
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx:
##########
@@ -44,6 +44,14 @@ const StyledSidebarFlex = styled(Flex)`
const StyledHeaderFlex = styled(Flex)`
padding: ${({ theme }) => theme.sizeUnit * 3}px;
+
+ & > * {
+ width: 100%;
+ }
Review Comment:
Can we check if this messes with any existing visuals?
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalContent/ConfigModalContent.tsx:
##########
@@ -105,6 +106,28 @@ function ConfigModalContent({
isChartCustomizationId(currentItemId) &&
chartCustomizationIds.includes(currentItemId);
+ const hasNoItems =
+ filterState.orderedIds.length === 0 &&
+ customizationState.orderedIds.length === 0;
+ const showEmptyState = hasNoItems || !currentItemId;
Review Comment:
I think we might need to check if we need to change the type of
currentItemId to be not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
