alexandrusoare commented on code in PR #38909:
URL: https://github.com/apache/superset/pull/38909#discussion_r3000706841
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalContent/ConfigModalContent.tsx:
##########
@@ -105,6 +106,28 @@ function ConfigModalContent({
isChartCustomizationId(currentItemId) &&
chartCustomizationIds.includes(currentItemId);
+ const hasNoItems =
+ filterState.orderedIds.length === 0 &&
+ customizationState.orderedIds.length === 0;
+ const showEmptyState = hasNoItems || !currentItemId;
Review Comment:
Looked into it, the type is fine as-is. `currentItemId: string` works
because when there are no filters, it becomes an empty string '', and the code
handles this with `!currentItemId` (empty string is falsy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
