bito-code-review[bot] commented on code in PR #38974: URL: https://github.com/apache/superset/pull/38974#discussion_r3015530005
########## docs/admin_docs/configuration/timezones.mdx: ########## @@ -20,7 +20,7 @@ To help make the problem somewhat tractable—given that Apache Superset has no To strive for data consistency (regardless of the timezone of the client) the Apache Superset backend tries to ensure that any timestamp sent to the client has an explicit (or semi-explicit as in the case with [Epoch time](https://en.wikipedia.org/wiki/Unix_time) which is always in reference to UTC) timezone encoded within. -The challenge however lies with the slew of [database engines](/admin-docs/databases#installing-drivers-in-docker) which Apache Superset supports and various inconsistencies between their [Python Database API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects) relying by default on the underlying Python type returned by the DB-API. Currently only a subset of the supported database engines work correctly with Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd to JSON with the server timezone, thus guaranteeing the client will display timestamps in a consistent manner irrespective of the client's timezone. +The challenge however lies with the slew of [database engines](/user-docs/databases#installing-drivers-in-docker) which Apache Superset supports and various inconsistencies between their [Python Database API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects) relying by default on the underlying Python type returned by the DB-API. Currently only a subset of the supported database engines work correctly with Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd to JSON with the server timezone, thus guaranteeing the client will display timestamps in a consistent manner irrespective of the client's timezone. Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Broken documentation link</b></div> <div id="fix"> The link to database engines includes an anchor #installing-drivers-in-docker that does not exist on the /user-docs/databases page, making the link broken. Consider removing the anchor to link to the page directly. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion The challenge however lies with the slew of [database engines](/user-docs/databases) which Apache Superset supports and various inconsistencies between their [Python Database API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects) relying by default on the underlying Python type returned by the DB-API. Currently only a subset of the supported database engines work correctly with Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd to JSON with the server timezone, thus guaranteeing the client will display timestamps in a consistent manner irrespective of the client's timezone. ```` </div> </details> </div> <small><i>Code Review Run #fd0b28</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -193,7 +193,7 @@ Access to dashboards is managed via owners and permissions. Non-owner access can through dataset permissions or dashboard-level roles (using the `DASHBOARD_RBAC` feature flag). For detailed information on configuring dashboard access, see the -[Dashboard Access Control](/admin-docs/security/security#dashboard-access-control) section in the +[Dashboard Access Control](/admin-docs/security/#dashboard-access-control) section in the Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Broken documentation link</b></div> <div id="fix"> This change appears to break the documentation link by removing the necessary '/security' path segment. The target file is at '/admin-docs/security/security.mdx', so the original path was correct. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion [Dashboard Access Control](/admin-docs/security/security#dashboard-access-control) section in the ```` </div> </details> </div> <small><i>Code Review Run #fd0b28</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/admin_docs/installation/kubernetes.mdx: ########## @@ -149,7 +149,7 @@ For production clusters it's recommended to build own image with this step done Superset requires a Python DB-API database driver and a SQLAlchemy dialect to be installed for each datastore you want to connect to. -See [Install Database Drivers](/admin-docs/databases#installing-database-drivers) for more information. +See [Install Database Drivers](/user-docs/databases#installing-database-drivers) for more information. Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Broken documentation link</b></div> <div id="fix"> The link to 'Install Database Drivers' now points to /user-docs/databases#installing-database-drivers, but this page does not exist in the documentation. This will result in a 404 error for users trying to access the installation instructions. The original link to /admin-docs/databases was also broken, so this change doesn't resolve the issue. Please verify the correct location of the 'Installing Database Drivers' content (e.g., based on versioned docs at /docs/6.0.0/configuration/databases#installing-database-drivers) and update accordingly. </div> </div> <small><i>Code Review Run #fd0b28</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
