Copilot commented on code in PR #38974:
URL: https://github.com/apache/superset/pull/38974#discussion_r3017438849
##########
docs/src/pages/index.tsx:
##########
@@ -717,7 +717,7 @@ export default function Home(): JSX.Element {
</span>
</div>
<img src="/img/community/line.png" alt="line" />
- <StyledButton className="default-button-theme" href="/docs/intro">
+ <StyledButton className="default-button-theme"
href="/user-docs/intro">
Review Comment:
This links to `/user-docs/intro`, but the docs config already defines a
redirect from `/user-docs/intro` to `/user-docs/`. Consider linking directly to
`/user-docs/` to avoid an extra redirect and keep it consistent with the navbar
"Get Started" link.
```suggestion
<StyledButton className="default-button-theme"
href="/user-docs/">
```
##########
docs/admin_docs/configuration/timezones.mdx:
##########
@@ -20,7 +20,7 @@ To help make the problem somewhat tractable—given that Apache
Superset has no
To strive for data consistency (regardless of the timezone of the client) the
Apache Superset backend tries to ensure that any timestamp sent to the client
has an explicit (or semi-explicit as in the case with [Epoch
time](https://en.wikipedia.org/wiki/Unix_time) which is always in reference to
UTC) timezone encoded within.
-The challenge however lies with the slew of [database
engines](/admin-docs/databases#installing-drivers-in-docker) which Apache
Superset supports and various inconsistencies between their [Python Database
API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations
combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read
SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores
the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects)
relying by default on the underlying Python type returned by the DB-API.
Currently only a subset of the supported database engines work correctly with
Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd
to JSON with the server timezone, thus guaranteeing the client will display
timestamps in a consistent manner irrespective of the client's timezone.
+The challenge however lies with the slew of [database
engines](/user-docs/databases#installing-drivers-in-docker) which Apache
Superset supports and various inconsistencies between their [Python Database
API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations
combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read
SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores
the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects)
relying by default on the underlying Python type returned by the DB-API.
Currently only a subset of the supported database engines work correctly with
Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd
to JSON with the server timezone, thus guaranteeing the client will display
timestamps in a consistent manner irrespective of the client's timezone.
Review Comment:
Typo in this paragraph: "serializd" should be "serialized".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
