serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r319224456
##########
File path: superset/common/query_context.py
##########
@@ -150,8 +155,8 @@ def cache_timeout(self):
return self.datasource.database.cache_timeout
return config.get("CACHE_DEFAULT_TIMEOUT")
Review comment:
Most of the code seems to assume that `config.get(KEY)` will never return
`None`, so I did typing under that assumption too. Not sure if that's ok? If we
are working under that assumption, could definitely change all
`config.get(KEY)` to `config[KEY]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
