serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r320398039
##########
File path: superset/connectors/base/models.py
##########
@@ -60,8 +60,8 @@ class BaseDatasource(AuditMixinNullable, ImportMixin):
perm = Column(String(1000))
sql = None
- owners = None
Review comment:
I don't think `owners` and `update_from_object_fields` are ever referenced
before they are assigned, so the default value isn't really necessary. But tbh,
I just removed the default value so I could add a non optional type, so I'm
fine with putting it back in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
