serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r321469672
##########
File path: superset/common/query_context.py
##########
@@ -148,10 +153,10 @@ def cache_timeout(self):
and self.datasource.database.cache_timeout
) is not None:
return self.datasource.database.cache_timeout
- return config.get("CACHE_DEFAULT_TIMEOUT")
+ return config["CACHE_DEFAULT_TIMEOUT"]
Review comment:
I think so - was discussed in earlier comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
