aminghadersohi opened a new pull request, #40022:
URL: https://github.com/apache/superset/pull/40022

   ### SUMMARY
   
   Replaces ALL CAPS button labels with Title Case to align with the Superset 
design system convention. Six labels across five files were using uppercase 
strings that violate the established button label style.
   
   Changes:
   - `DateFilterLabel.tsx`: `CANCEL` → `Cancel`, `APPLY` → `Apply`
   - `AnnotationLayer.tsx`: `OK` → `Confirm`
   - `DatasourceModal/index.tsx`: `OK` → `Confirm`
   - `Tabs.tsx`: `DELETE` → `Delete`
   - `ResultSet/index.tsx`: `OK` → `Confirm`
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: Button labels displayed in ALL CAPS (e.g. CANCEL, APPLY, OK, DELETE)
   After: Button labels displayed in Title Case (e.g. Cancel, Apply, Confirm, 
Delete)
   
   ### TESTING INSTRUCTIONS
   
   1. Open the Date Filter control → verify Cancel and Apply buttons are title 
case
   2. Open an Annotation Layer → verify the submit button shows "Confirm"
   3. Open a Datasource modal and trigger the confirm save dialog → verify 
"Confirm" button
   4. On a dashboard with tabs, delete a tab → verify the danger button shows 
"Delete"
   5. In SQL Lab, run a large query and export → verify the confirmation dialog 
shows "Confirm"
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to