bito-code-review[bot] commented on code in PR #40022:
URL: https://github.com/apache/superset/pull/40022#discussion_r3219463525
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -328,7 +328,7 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
onClick={onHide}
data-test={DateFilterTestKey.CancelButton}
>
- {t('CANCEL')}
+ {t('Cancel')}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test expectation mismatch</b></div>
<div id="fix">
Update DateFilterLabel.test.tsx to expect 'Cancel' instead of 'CANCEL' and
'Apply' instead of 'APPLY' in the popover tests.
</div>
</div>
<small><i>Code Review Run #ee6107</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
