bito-code-review[bot] commented on code in PR #40048:
URL: https://github.com/apache/superset/pull/40048#discussion_r3226282431
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -328,7 +328,7 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
onClick={onHide}
data-test={DateFilterTestKey.CancelButton}
>
- {t('CANCEL')}
+ {t('Cancel')}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test expectations mismatch</b></div>
<div id="fix">
Changing translation keys from 'CANCEL' to 'Cancel' and 'APPLY' to 'Apply'
updates the button text in the date filter popover. However, the tests in
DateFilterLabel.test.tsx still expect the old uppercase labels, causing
failures. Update the test expectations to match the new button text for
consistency with the rest of the codebase, which predominantly uses title case
for these buttons.
</div>
</div>
<small><i>Code Review Run #231865</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
