graceguo-supercat commented on a change in pull request #8166:
[feature][dashboard] Show/hide filter indicator on the applicable charts when
filter options are open/close
URL:
https://github.com/apache/incubator-superset/pull/8166#discussion_r321957342
##########
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##########
@@ -338,7 +365,7 @@ export default class DateFilterControl extends
React.Component {
});
return (
<Popover id="filter-popover" placement="top" positionTop={0}>
- <div style={{ width: '250px' }}>
+ <div style={{ width: '250px' }} ref={(ref) => { this.popoverContainer
= ref; }}>
Review comment:
i fixed one place. there are quite a few inline css in this file and in the
code base. we probably need to find a rule or consistent way to style component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
