graceguo-supercat commented on a change in pull request #8166:
[feature][dashboard] Show/hide filter indicator on the applicable charts when
filter options are open/close
URL:
https://github.com/apache/incubator-superset/pull/8166#discussion_r322505981
##########
File path: superset/assets/src/dashboard/components/gridComponents/Chart.jsx
##########
@@ -169,6 +172,14 @@ class Chart extends React.Component {
this.props.changeFilter(this.props.chart.id, newSelectedValues);
}
+ handleFilterMenuOpen(chartId, column) {
+ this.props.setFocusedFilterField(chartId, column);
+ }
+
+ handleFilterMenuClose() {
+ this.props.setFocusedFilterField();
Review comment:
the purpose of empty parameter here is to clear/unset focused filter field
state.
I thought we prefer no params than explicitly `null` params? I rarely see
any example in our code that explicitly pass a `null` to function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
