graceguo-supercat commented on a change in pull request #8166:
[feature][dashboard] Show/hide filter indicator on the applicable charts when
filter options are open/close
URL:
https://github.com/apache/incubator-superset/pull/8166#discussion_r322505075
##########
File path:
superset/assets/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -64,49 +65,79 @@ const propTypes = {
const defaultProps = {
directPathToChild: [],
+ directPathLastUpdated: 0,
};
class ChartHolder extends React.Component {
- static renderInFocusCSS(labelName) {
+ static renderInFocusCSS(columnName) {
return (
<style>
- {`.inFocus label[for=${labelName}] + .Select .Select-control {
- border: 2px solid #00736a;
+ {`label[for=${columnName}] + .Select .Select-control {
Review comment:
I can also pass the selected filter field as prop to filter_box component.
But first, it is deeply nested inside Chart component. And since it is a data
visualization component, its props needs to be validated from superset-ui chart
props.
If I pass selected column name to filter_box component, it will be 100 times
more troublesome than 2 lines of inline css. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
