bito-code-review[bot] commented on code in PR #40048:
URL: https://github.com/apache/superset/pull/40048#discussion_r3229787490
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx:
##########
@@ -236,7 +236,7 @@ test('Disable apply button if formula is incorrect', async
() => {
const formulaInput = screen.getByRole('textbox', { name: 'Formula' });
const applyButton = screen.getByRole('button', { name: 'Apply' });
- const okButton = screen.getByRole('button', { name: 'OK' });
+ const okButton = screen.getByRole('button', { name: 'Confirm' });
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Misleading button reference in tests</b></div>
<div id="fix">
The diff updates button queries from 'OK' to 'Confirm' to match the
component change, but the variable name 'okButton' and test descriptions still
reference 'ok', creating misleading inconsistency that could confuse developers
reading the tests.
</div>
</div>
<small><i>Code Review Run #0b1a05</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
