bito-code-review[bot] commented on PR #40124:
URL: https://github.com/apache/superset/pull/40124#issuecomment-4455644944
<!-- Bito Reply -->
The schema description for `target_tab` currently states that matching
ignores leading/trailing emoji, but the `_normalize_tab_text()` function strips
emoji from anywhere in the string, along with trimming whitespace and
lowercasing. To accurately reflect the behavior, update the description to
mention ignoring all emoji, trimming whitespace, and case-insensitivity.
**superset/mcp_service/dashboard/schemas.py**
```
target_tab: str | None = Field(
None,
description=(
"Tab to place the chart in. Accepts a tab display name "
"(e.g. 'Sales') or a tab component ID (e.g. 'TAB-abc123'). "
"Matching is case-insensitive, ignores all emoji, and trims
whitespace. "
"Returns an error if the specified tab is not found. "
"When omitted on a tabbed dashboard the chart is placed in the "
"first tab. Use get_dashboard_info to discover available tabs."
),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
