aminghadersohi commented on PR #40124:
URL: https://github.com/apache/superset/pull/40124#issuecomment-4522968646
@fitzee Both nits addressed — thanks for the clear write-ups.
**Empty-string `target_tab` rejected at schema layer**: Added `min_length=1`
to the `target_tab` field in `AddChartToDashboardRequest`. A schema test
(`test_empty_target_tab_rejected_by_schema`) verifies that `target_tab=""`
raises a Pydantic `ValidationError` before reaching business logic, while
`None` remains valid. (commit `1feae59ad9`)
**`assert` → `RuntimeError`**: Replaced `assert parent_id is not None` with:
```python
if parent_id is None:
raise RuntimeError("unreachable: tab_error is None implies parent_id is
str")
```
(same commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
