aminghadersohi commented on code in PR #40124:
URL: https://github.com/apache/superset/pull/40124#discussion_r3266862273
##########
superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py:
##########
@@ -316,6 +333,46 @@ def _ensure_layout_structure(
layout["DASHBOARD_VERSION_KEY"] = "v2"
+def _resolve_parent_container(
+ layout: Dict[str, Any],
+ dashboard_id: int,
+ target_tab: str | None,
+) -> tuple[str, None] | tuple[None, AddChartToDashboardResponse]:
+ """Return (parent_id, None) on success or (None, error_response) on
mismatch.
+
+ When *target_tab* is specified and not found the caller receives a
+ descriptive error listing available tabs rather than a silent fallback.
+ """
+ tab_target = _find_tab_insert_target(layout, target_tab=target_tab)
+
+ if target_tab is not None and tab_target is None:
+ available = _collect_available_tab_names(layout)
+ if available:
+ tab_list = ", ".join(f"'{t}'" for t in available)
+ return None, AddChartToDashboardResponse(
+ dashboard=None,
+ dashboard_url=None,
+ position=None,
+ error=(
+ f"Tab '{target_tab}' not found in dashboard
{dashboard_id}. "
+ f"Available tabs: {tab_list}. "
+ "Use get_dashboard_info to inspect the tab structure."
+ ),
Review Comment:
Fixed. The error message and field description no longer reference
`get_dashboard_info` for tab discovery. The error response is now
self-contained: it lists the available tab names directly (e.g., `Available
tabs: 'Sales', 'Revenue'`), so callers don't need to call another tool to
discover tab names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
