aminghadersohi commented on PR #40339: URL: https://github.com/apache/superset/pull/40339#issuecomment-4556801783
Thanks for the detailed review! All three points addressed in `1d276e67b2`: 1. **`point_radius_fixed` metrics** — extracted `_resolve_deck_gl_metrics` that collects `size`, `metric`, and `point_radius_fixed["value"]` when `type == "metric"`, so deck_scatter radius metrics and deck_polygon elevation metrics are now included. 2. **IS NOT NULL null filters** — added `_deck_gl_null_filters` that mirrors `BaseDeckGLViz.add_null_filters()`: builds IS NOT NULL simple filters for all spatial control columns and `line_column`, applied by default when `filter_nulls` is not explicitly `False`. 3. **Tooltip / cross-filter columns** — added `_deck_gl_tooltip_cols` helper and extended `resolve_deck_gl_columns` to include `tooltip_contents` column items (`item_type == "column"`) and `cross_filter_column`. Unit tests added for all three helpers and the integrated `build_query_dicts_from_form_data` behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
