aminghadersohi commented on PR #40339: URL: https://github.com/apache/superset/pull/40339#issuecomment-4558679387
Fixed in `e32a683f6f1d1115dd188175b44133c9e24be3ee` — `point_radius_fixed` as a bare non-numeric string is now included via `_is_metric_ref`, matching the frontend `isMetricValue()` behavior for legacy `deck_scatter` charts. The `elif _is_metric_ref(prf)` branch handles the case where `point_radius_fixed` is a string like `"count"` (not a dict), so older `deck_scatter` charts without saved `query_context` now include the radius metric in the fallback query. Numeric strings like `"100"` (fixed pixel radius) are still excluded via the `float()` try/except in `_is_metric_ref`. Added two new tests: - `test_resolve_deck_gl_metrics_string_point_radius_fixed` — bare string `"count"` → `["count"]` - `test_resolve_deck_gl_metrics_numeric_point_radius_fixed_excluded` — `"100"` → `[]` - `test_build_query_dicts_deck_scatter_string_point_radius_fixed` — integration test via `build_query_dicts_from_form_data` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
