aminghadersohi commented on PR #40339:
URL: https://github.com/apache/superset/pull/40339#issuecomment-4558268271
Thanks for the continued review — both points from `4375664950` are
addressed in `362b9faaab`.
**`chart_helpers.py:325` — string metric keys like `"count"` silently
dropped**
Added `_is_metric_ref()` that accepts dicts *and* non-numeric strings while
rejecting numeric scalars (`"100"`, `100`). `_resolve_deck_gl_metrics` now uses
it for both `size` and `metric` fields, so saved metric string keys (e.g.
`size: "count"`) are preserved.
**`chart_helpers.py:549` — `deck_geojson` geojson column not null-filtered**
Extended `_deck_gl_null_filters()` to also add `IS NOT NULL` for the
`geojson` and `line_column` fields (using a unified loop over both).
`deck_geojson` fallback queries now include `geojson IS NOT NULL` when
`filter_nulls` is not disabled.
New tests cover both behaviours, including a `deck_hex` string-metric
integration test and a `deck_geojson` null-filter integration test.
**Re: the original `point_radius_fixed` question from `4374013012`** — that
was addressed in `1d276e67b2` which added the `prf.get("type") == "metric"`
check (lines 327–331 in the current file). For `point_radius_fixed` as a bare
string (`"count"`), `viz.py` itself would crash at `.get("type")` so that case
is intentionally left as dict-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
