shelkesays commented on issue #40511: URL: https://github.com/apache/superset/issues/40511#issuecomment-4571541067
@dosu thanks for the confirmation. Quick note on the file paths: after PR #37018 the refresh logic moved out of `Header/index.jsx` and into `Header/useHeaderAutoRefresh.ts`, and `dashboardState.js` is now `dashboardState.ts`. Anyone looking at master will not see the line numbers above. PR #40512 takes the same direction you described. The small difference is that it adds an opt-in server config `SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS` (defaulting to 5000) so operators can set a global default without asking every dashboard owner to edit JSON metadata. The per-dashboard `stagger_time` metadata still wins where larger, since `fetchCharts` uses `Math.max(interval, stagger_time || 5000)`. Setting the config to 0 keeps the old unstaggered behavior for anyone who wants it. The deeper refactor you mentioned, where the staggering branch in `fetchCharts` keys off `stagger_refresh` instead of `interval`, sounds like a cleaner end state. Happy to take that on in a follow-up if maintainers prefer it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
