shelkesays commented on issue #40511:
URL: https://github.com/apache/superset/issues/40511#issuecomment-4571646489
@dosu thanks for the response. To help anyone reading along who might
compare references, I double-checked the current apache/master tree at
`b0da0cf202` and a few things look different from what was described.
Looking at master right now:
- `useHeaderAutoRefresh.ts` is already present. It was introduced by PR
#37459 ("feat: auto refresh dashboard") and is the file this PR modifies rather
than creating.
https://github.com/apache/superset/blob/b0da0cf202/superset-frontend/src/dashboard/components/Header/useHeaderAutoRefresh.ts
- `dashboardState` is `.ts` on master, not `.js`.
https://github.com/apache/superset/blob/b0da0cf202/superset-frontend/src/dashboard/actions/dashboardState.ts
- `useHeaderActionsDropdownMenu.tsx` does exist (added by PR #31972 during
the Ant Design 5 migration), but it is the dropdown menu, not the refresh hook.
I also want to correct myself: in my previous comment I said
`useHeaderAutoRefresh.ts` came from PR #37018. That was wrong on my part. PR
#37018 is the nested-tab cascade fix that added `handledRefreshRef` and
`isLazyLoad` to `Tab.tsx` and `dashboardState.ts`. The hook itself came from PR
#37459, per the commit history. Apologies for any confusion that caused.
So the picture for human reviewers: on current master, the manual refresh
callback flows through `useHeaderAutoRefresh.forceRefresh` in
`useHeaderAutoRefresh.ts`, and the staggered branch lives in `fetchCharts` in
`dashboardState.ts`. PR #40512 modifies both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
