dosubot[bot] commented on issue #40511: URL: https://github.com/apache/superset/issues/40511#issuecomment-4571558983
<!-- Answer --> Thanks for the correction on the file paths — I appreciate you flagging that. To clarify what I'm seeing on master right now: `dashboardState` is still `.js` (not `.ts`) and `useHeaderAutoRefresh.ts` appears to be introduced by your PR #40512 rather than by #37018 [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/actions/dashboardState.js) [[2]](https://github.com/apache/superset/pull/40512). The current master has the refresh callback in `useHeaderActionsDropdownMenu.tsx` [[3]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx). So anyone reading along should look there for the existing behavior. Regarding the approach in PR #40512 — the server-side `SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS` config is a nice touch. Giving operators a global knob avoids the per-dashboard JSON editing burden, and having `stagger_time` win when larger preserves the existing contract for dashboards that already customized their metadata. Defaulting to 5000ms and allowing `0` to opt out keeps it backwards-compatible. The deeper refactor (keying off `stagger_refresh` metadata instead of `interval`) would decouple "should we stagger?" from "is this a periodic refresh?" which is conceptually cleaner, but it's a bigger change surface. Doing it as a follow-up makes sense — the immediate fix in #40512 solves the user-facing problem without restructuring the control flow. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).* --- Share context across your team and agents. Try [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-tagline&utm_term=apache%2Fsuperset). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-feedback&utm_term=apache%2Fsuperset&message_id=397ae6e0-080e-44cb-91dd-440d75156894) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-learn-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-add-team&utm_term=apache%2Fsuperset) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
