shelkesays commented on PR #40512: URL: https://github.com/apache/superset/pull/40512#issuecomment-4571757202
Thanks for the review. Addressing both points: **Actionable (exact default value assertion)**: applied in commit 2720d32994. The default-case test now uses `expect(interval).toBe(5000)` and the test name calls out the exact value, matching the style of the `12000` and `0` cases. **Additional (chart filtering test)**: fair observation, but the chart-filtering branch in `executeRefresh` is pre-existing behavior that this PR does not modify. The filter at `useHeaderAutoRefresh.ts:136-142` was added by PR #37459 and was working as-is before this change. Adding tests for code we did not touch widens the PR scope beyond the stagger logic. I would rather keep the new test surface focused on what this PR introduces. Happy to file a follow-up issue or contribute that coverage separately if a maintainer feels it should land alongside this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
